rename KeyMap -> Map, DequeStore -> Deque#74
Open
eshelB wants to merge 5 commits intomatch-cw-storage-plus-basefrom
Open
rename KeyMap -> Map, DequeStore -> Deque#74eshelB wants to merge 5 commits intomatch-cw-storage-plus-basefrom
eshelB wants to merge 5 commits intomatch-cw-storage-plus-basefrom
Conversation
eshelB
added
the
match cw-storage-plus
toml01
reviewed
Feb 23, 2023
Member
toml01
left a comment
toml01
left a comment
There was a problem hiding this comment.
Should we change Keyset -> Set to match the new naming scheme?
|
|
||
| - Added the `Keyset` storage object (A hashset like storage object). | ||
| - Allowed further customisation of Keymap and Keyset with new constructor structs called `KeymapBuilder` and `KeysetBuilder` which allow the user to disable the iterator feature (saving gas) or adjust the internal indexes' page size so that the user may determine how many objects are to be stored/loaded together in the iterator. | ||
| - Allowed further customisation of Map and Keyset with new constructor structs called `MapBuilder` and `KeysetBuilder` which allow the user to disable the iterator feature (saving gas) or adjust the internal indexes' page size so that the user may determine how many objects are to be stored/loaded together in the iterator. |
Member
There was a problem hiding this comment.
Since this is a changelog, I guess it makes sense to keep it as it was and add a bullet specifying the name change
williamj056
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.